Refactor building #1332
Merged
Refactor building #1332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
monadbobo,
yixinglu,
sherman-the-tank,
CPWstatic,
dangleptr and
laura-ding
Fixed for CentOS 6 Support to custom download_dir Added s2geometry Detect version of cmake Added build-cmake.sh Download third-party from oss Fixed issue due to wget compatibility Clean build-third-party.sh Fixed building scripts Fix building Fix build-cmake.sh Fix checksum
laura-ding
reviewed
Nov 27, 2019
laura-ding
reviewed
Nov 27, 2019
laura-ding
reviewed
Nov 27, 2019
laura-ding
reviewed
Nov 28, 2019
dangleptr
reviewed
Nov 29, 2019
laura-ding
reviewed
Dec 27, 2019
laura-ding
previously approved these changes
Dec 31, 2019
laura-ding
approved these changes
Dec 31, 2019
This was referenced Dec 31, 2019
CPWstatic
approved these changes
Jan 1, 2020
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
This PR is trying to improve the building experience, by: 1. Providing `third-party/install-cmake.sh` to download and install a prebuilt CMake 2. Providing `third-party/build-gcc.sh` to automatically download and build GCC 7.5.0 3. Providing `third-party/install-gcc.sh` to download and install a prebuilt GCC 7.5.0 according to the current distro and libc 4. Providing `third-party/build-third-party.sh` to build and optionally package our third party dependencies 4. Providing `third-party/build-all-third-party.sh` to invoke `build-third-party.sh` using several preset versions of GCC 5. Providing `third-party/install-third-party.sh` to download and install a prebuilt third party according to the current version of glibc, GCC(along with its ABI version) 6. Invoke `install-third-party.sh` automatically during the configure stage(cmake) Besides, all installing scripts support an `--prefix` option to allow one customizing the install location. For the third party installation, works are done to make *Bison* and *krb5* relocatable. The fresh new building shceme has been tested under various environments: 1. CentOS 6/7/8 2. Debian 7/8/9 3. Ubuntu 16.04/18.04/19.04 4. GCC 7/8/9, and devtoolset-7 of CentOS 6/7 Since most of these testing are from inside a Docker image, so the Linux Kernel used is nearly the newest one(5.0). There might be other unfound issues. To try out this PR, run ```sh $ git clone --single-branch --depth=1 --branch refactor-building https://github.com/dutor/nebula.git nebula-refactor-building $ cd nebula-refactor-building $ mkdir build && cd build $ ../third-party/install-cmake.sh # Can be skipped if you have CMake 3.5.0+ $ source cmake-3.15.5/bin/enable-cmake.sh # Only necessary if you invoked install-cmake.sh $ sudo ../third-party/install-gcc.sh # Can be skipped if you have GCC 7.1.0+ $ source /opt/vesoft/toolset/gcc/7.5.0/enable # Only necessary if you invoked install-gcc.sh $ cmake .. $ make ``` BTW. This PR also fixes vesoft-inc#1449 BTW. This PR reduces the build size a lot, as mentioned in vesoft-inc#1401
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* support_rocksdb_cloud * clear unused code * fix cmakelist.txt code format Co-authored-by: Sophie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is trying to improve the building experience, by:
third-party/install-cmake.shto download and install a prebuilt CMakethird-party/build-gcc.shto automatically download and build GCC 7.5.0third-party/install-gcc.shto download and install a prebuilt GCC 7.5.0 according to the current distro and libcthird-party/build-third-party.shto build and optionally package our third party dependenciesthird-party/build-all-third-party.shto invokebuild-third-party.shusing several preset versions of GCCthird-party/install-third-party.shto download and install a prebuilt third party according to the current version of glibc, GCC(along with its ABI version)install-third-party.shautomatically during the configure stage(cmake)Besides, all installing scripts support an
--prefixoption to allow one customizing the install location. For the third party installation, works are done to make Bison and krb5 relocatable.The fresh new building shceme has been tested under various environments:
Since most of these testing are from inside a Docker image, so the Linux Kernel used is nearly the newest one(5.0). There might be other unfound issues.
To try out this PR, run
BTW. This PR also fixes #1449
BTW. This PR reduces the build size a lot, as mentioned in #1401